EC-960 Remove last remnants of go-getter #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit bumps the dependency version for go-gather. Ref: EC-960 Signed-off-by: robnester-rh <[email protected]>
This commit removes "github.com/hashicorp/go-getter" as a direct dependency. It does remain as an indirect dependency, however. Ref: EC-960 Signed-off-by: robnester-rh <[email protected]>
This commit refactors `git-config` to use the detector methods from the `github.com/enterprise-contract/go-gather/detector` package. Signed-off-by: robnester-rh <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2300 +/- ##
==========================================
+ Coverage 72.77% 72.79% +0.02%
==========================================
Files 89 89
Lines 7676 7687 +11
==========================================
+ Hits 5586 5596 +10
- Misses 2090 2091 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
simonbaird
reviewed
Feb 5, 2025
simonbaird
reviewed
Feb 5, 2025
simonbaird
approved these changes
Feb 5, 2025
This commit restores a TestSourceIsFile case. Signed-off-by: robnester-rh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes any direct dependencies on go-getter and replaces them with go-gather as appropriate. Note that go-getter does remain as an indirect dependency.